[Feature Request] Replace - by : during scraping

Flutterando / yuno

Minimal Open-source Retrogame Frontend

Other

113 stars 29 forks source link

[Feature Request] Replace - by : during scraping #13

Open GlazedBelmont opened 8 months ago

GlazedBelmont commented 8 months ago

A popular method of having : in a filename is replacing it with a - so during scraping, the application asks replaces it with : during its request. "Captain Toad - Treasure Tracker" -> "Captain Toad: Treasure Tracker"

otherwise IGDB could match false positives and fetch the wrong cover art.

jacobaraujo7 commented 8 months ago

Today, if you change the title and resync it solves the problem in the scrapper. Wouldn't that be enough?

GlazedBelmont commented 8 months ago

it does not seem to fix it, it still grabs "Captain Toad Treasure Tracker (2016)"

jacobaraujo7 commented 8 months ago

I'm sorry. It may be my English, but I'm having a little trouble understanding it. Could you explain the problem to me again?

GlazedBelmont commented 8 months ago

codetrindade commented 7 months ago

I'm sorry. It may be my English, but I'm having a little trouble understanding it. Could you explain the problem to me again?

The concern is that when scraping data from IGDB, some game titles have ':' in their names, but during requests, it's replaced with '-'. For example, 'Captain Toad - Treasure Tracker' becomes 'Captain Toad: Treasure Tracker.' The worry is about potential false positives and fetching incorrect cover art due to this replacement in the request.

GlazedBelmont commented 7 months ago

Other way around, it doesn't seem to replace '-' with ':' and this leads to less accurate scraping because IGDB expects ':'

Message ID: @.***>