search

Flutterish / Hitokori

A custom osu! ruleset based on a dance of fire and ice
MIT License
110 stars 18 forks source link

Gameset wont register in version 2024 625.2 and higher #51

Closed dudasmarcus closed 1 week ago

dudasmarcus commented 2 months ago

Upon the new update the ruleset wont load properly anymore

2024-07-11 19:25:12 [verbose]: at osu.Game.Rulesets.RulesetStore.addRuleset(Assembly assembly) 2024-07-11 19:25:13 [error]: Could not load ruleset "hitokori". Please check for an update from the developer. 2024-07-11 19:25:13 [verbose]: Ruleset load failed: System.MissingMethodException: Method not found: 'Void osu.Game.Beatmaps.Beatmap1.set_Breaks(System.Collections.Generic.List1)'. 2024-07-11 19:25:13 [verbose]: at osu.Game.Rulesets.Hitokori.Beatmaps.HitokoriBeatmapConverter.GenerateBreaks(HitokoriBeatmap Beatmap) 2024-07-11 19:25:13 [verbose]: at osu.Game.Rulesets.Hitokori.Beatmaps.HitokoriBeatmapConverter.ConvertBeatmap(IBeatmap original, CancellationToken cancellationToken) 2024-07-11 19:25:13 [verbose]: at osu.Game.Beatmaps.BeatmapConverter`1.Convert(CancellationToken cancellationToken) 2024-07-11 19:25:13 [verbose]: at osu.Game.Rulesets.RealmRulesetStore.testRulesetCompatibility(RulesetInfo rulesetInfo) 2024-07-11 19:25:13 [verbose]: at osu.Game.Rulesets.RealmRulesetStore.b__5_0(Realm realm)

necocat0918 commented 3 weeks ago

I can try fix it lemme try

EDIT: Issue is found, fixing it I'll send it here once I'm done

necocat0918 commented 3 weeks ago

Issue Fixed Although it is able to run, it causes crash on my computer (which is now fixed in 2024.8.20, shout out peppy) To Hitokori Devs, there IS the fixed source code https://mega.nz/file/yBYSmBKB#b9wsKlgjI0voko7bBfJwrbxIWKAdFhhGwdKdLSYGfww

(DrawableHitokoriJudgement.cs and HitokoriBeatmapConverter.cs are changed)

dudasmarcus commented 2 weeks ago

2024.817.0-lazer broken once more. it is able to run, then it crashes immediately after loading the beatmap and the sprites

necocat0918 commented 2 weeks ago

no way this is already fixed in the given link

okay sorry my bad https://mega.nz/file/nRwAwTjK#svCTHdWjWKWQj0wI1xnF6T7RPGa560DW-AeEviSieLc

dudasmarcus commented 2 weeks ago

I fear not. It just loads, plays the beatmap for maybe 3 secs then crashes every time... And it wont even give me any traceback of what happened

Dňa st 28. 8. 2024, 6:29 Necodev @.***> napísal(a):

no way this is already fixed in the given link

— Reply to this email directly, view it on GitHub https://github.com/Flutterish/Hitokori/issues/51#issuecomment-2314227229, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4QWAKBO6W2CUMMO5O7ZMSDZTVGZRAVCNFSM6AAAAABKXTE47WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUGIZDOMRSHE . You are receiving this because you authored the thread.Message ID: @.***>

necocat0918 commented 2 weeks ago

no no no use the new link and download it I am sure it is the working version

dudasmarcus commented 1 week ago

It works! Im replying from gmail and i didnt seem the mega link on your second to last message.

Imma close this once im on github

Dňa št 29. 8. 2024, 14:16 Necodev @.***> napísal(a):

no no no use the new link and download it I am sure it is the working version

— Reply to this email directly, view it on GitHub https://github.com/Flutterish/Hitokori/issues/51#issuecomment-2317485066, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4QWAKAQUOD7LI7NRS2SO3DZT4GJPAVCNFSM6AAAAABKXTE47WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGQ4DKMBWGY . You are receiving this because you authored the thread.Message ID: @.***>