Flutterwave / PHP-v3

PHP Library for Flutterwave v3 APIs

MIT License

19 stars 18 forks source link

Improve PHPUnit version semver and array syntax #19

Closed peter279k closed 3 years ago

peter279k commented 3 years ago

Changed log

Adding the ^4.8.36 for the PHP 5.4 versions during PHPUnit tests.
Replace the short array syntax with array syntax since this SDK requires php-5.4 version at least.

corneliusyaovi commented 3 years ago

Hello @peter279k,

Thanks for taking the time to contribute to our codebase.

Please can you share your motivation for adding backward compatibility to your commit i.e. supporting php-5.4.

We'd really love to hear from you.

Regards, Cornelius.

peter279k commented 3 years ago

Adding the ^4.8.36 for the PHP 5.4 versions during PHPUnit tests.

This is backward compatibility for supporting php-5.4 version when executing some PHPUnit tests.

Replace the short array syntax with array syntax since this SDK requires php-5.4 version at least.

This is about array syntax improvements since this PHP package requires php-5.4 version.

corneliusyaovi commented 3 years ago

Hello @peter279k,

Thank you very much for making out time to contribute to our code.

We would like to inform you that we would not be merging your PR at the moment. We want to encourage you to keep contributing to our codebase to help us make it better.

Thanks, Cornelius.