search

FluuxIO / go-xmpp

Native Go XMPP library
https://www.process-one.net/
BSD 3-Clause "New" or "Revised" License
317 stars 63 forks source link

Remove "no depdencies" statement from README #150

Closed jacksgt closed 4 years ago

jacksgt commented 4 years ago

As is apparent from the current go.mod file, this library definitely depends on various other libraries. This in turn makes it depend on Go 1.13 (currently).

p1bot commented 4 years ago

Hi @jacksgt, many thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

p1bot commented 4 years ago

You did it @jacksgt!

Thank you for signing the ProcessOne Contribution License Agreement.

We will have a look at your contribution!

mremond commented 4 years ago

I think the goal is still really to have the minimum set of dependancies for the core.

Maybe some of the root go.mod dependencies can be moved to examples?

remicorniere commented 4 years ago

Unfortunately, the websocket part of the library currently uses this lib (which seems to require Go 1.13). I don't see how we can move this dependency without reworking the websockets part.

mremond commented 4 years ago

Hi, basically, saying only dependency is on this websocket library is fine. However, we also depend on gocui and viper. It should not be needed in the core of the lib.

wichert commented 4 years ago

I suspect you can replace xerrors with native GO 1.13 errors as well.

remicorniere commented 4 years ago

@wichert xerrors are currently used in a few places, admittedly not that many. But just removing them from the go.mod should not work yet

jacksgt commented 4 years ago

I highly appreciate your desire to keep the dependencies as minimal as possible. Especially things like requiring the latest version of Go can be a real blocker in some environments.

Keep up the great work, thanks!

remicorniere commented 4 years ago

Thanks a lot !