search

FluxML / Alloc.jl

26 stars 1 forks source link

refactor & make it compatible with Zygote #1

Closed Roger-luo closed 4 years ago

Roger-luo commented 5 years ago

I removed dependency on IRTools, since it seems to be easier to implement this one with Cassette itself already. I'll merge this later and setup a CI since this package just started... if there's no comments. I'll maintain this package from now as well.

Roger-luo commented 5 years ago

There are some Cassette performance issue as well, I'll investigate that in another PR.

MikeInnes commented 4 years ago

Do we need the dependency on Zygote here? I think it'd be better to stick to IRTools for simplicity here.

Roger-luo commented 4 years ago

I think those are necessary to prevent potential slow down (at least based on last time I checked). Yeah I can change it to IRTools later, just doing mid term recently... and do you have time to look into that IR transformation issue in IRTools? I think I'll meet the same thing here https://github.com/MikeInnes/IRTools.jl/issues/21

Roger-luo commented 4 years ago

I noticed you've updated the repo. I'll close this then.