search

FluxML / FastAI.jl

Repository of best practices for deep learning in Julia, inspired by fastai
https://fluxml.ai/FastAI.jl
MIT License
588 stars 51 forks source link

Functions `getcoltypes` and `gettransformdict` are not exported properly #210

Closed ShuhuaGao closed 2 years ago

ShuhuaGao commented 2 years ago

When following the Tabular Classification tutorial, I encountered the following error: UndefVarError: getcoltypes not defined.

The reason is that these symbols are not exported in "Tabular.jl" and thus not exported by FastAI through @reexport using .Tabular.

I can make a PR. However, I am not clear about your original intention. Do you want FastAI.getcoltypes or Tabular.getcoltypes? The latter works now without changing the source code.

lorenzoh commented 2 years ago

The later version with FastAI prefix should be in the docs. Thanks for reporting! Ill keep this open until I fix the docs

ShuhuaGao commented 2 years ago

Did you mean FastAI.getcoltypes is the prefered one? I will also try to make a PR along with my learning of FastAI.jl. Thanks for the excellent work.

lorenzoh commented 2 years ago

Tabular.getcoltypes should be used is what I meant 👍 happy to review a PR

lorenzoh commented 2 years ago

Notebook has been updated, so closing this