FluxML / FastAI.jl

Repository of best practices for deep learning in Julia, inspired by fastai
https://fluxml.ai/FastAI.jl
MIT License
589 stars 51 forks source link

Makie 0.17 support #224

Closed lorenzoh closed 2 years ago

lorenzoh commented 2 years ago

When using Makie.jl 0.17, there are some errors cropping (see https://github.com/FluxML/FastAI.jl/runs/6404954707?check_suite_focus=true) up in the code for showing multiple observations, here: https://github.com/FluxML/FastAI.jl/blob/2f227aab66bdb554b6a628903a618a57dbc290c3/src/interpretation/makie/showmakie.jl#L54-L58

This code tries to add titles to the beginning of each column of a previously created GridLayout.

lorenzoh commented 2 years ago

Current plan is to create a separate package FastMakie.jl that holds the Makie-related code. This way, we won't need Requires.jl and FastAI.jl + domain libraries can depend on MakieCore.jl to define recipes for visualizing their Blocks