search

FluxML / FastAI.jl

Repository of best practices for deep learning in Julia, inspired by fastai
https://fluxml.ai/FastAI.jl
MIT License
585 stars 51 forks source link

Textmodel integration #248

Closed Chandu-4444 closed 2 years ago

Chandu-4444 commented 2 years ago

I've copied the customlayers.jl from TextModels.jl package. I can say that these were working fine except the reset! function (that's the reason I've commented it out). Even though it is working fine, the pretrained were terrible and weren't different from random ones.

ToucheSir commented 2 years ago

Could you note in the source which parts were copied from textmodels?

Chandu-4444 commented 2 years ago

Only src/Textual/models/customlayers.jl has been copied from TextModels.jl. The training loop and all has to be modified to work with DataLoaders.jl, so I didn't copy that yet.

lorenzoh commented 2 years ago

Can you base this on #245 with the new file structure?

Chandu-4444 commented 2 years ago

Can you base this on #245 with the new file structure?

I didn't get that?

lorenzoh commented 2 years ago

245 moves the text-related files to a folder FastText which is a new subpackage. This PR should also add files to FastText/src instead of FastAI/src/Textual so that it's easier to merge

Chandu-4444 commented 2 years ago

245 moves the text-related files to a folder FastText which is a new subpackage. This PR should also add files to FastText/src instead of FastAI/src/Textual so that it's easier to merge

Sure! I'll pull the code and will do that after #245 has been merged.