So this is a first draft for adding Optimisers.jl support (new optims) while keeping compatibility with optimisers in Flux.Optimise (old optims).
Passing in new optims already works, but I've broken support for old optims. Before, FluxTraining.jl was using implicit parameters with Params and Grads objects. I'm not sure how to use the old optims with explicit parameters to gradient.
I'll leave some more questions next to the code changes, some feedback from you two would be much appreciated!
Closes #112 (once done). @ToucheSir @darsnack
So this is a first draft for adding Optimisers.jl support (new optims) while keeping compatibility with optimisers in
Flux.Optimise
(old optims).Passing in new optims already works, but I've broken support for old optims. Before, FluxTraining.jl was using implicit parameters with
Params
andGrads
objects. I'm not sure how to use the old optims with explicit parameters togradient
.I'll leave some more questions next to the code changes, some feedback from you two would be much appreciated!