FluxML / FluxTraining.jl

A flexible neural net training library inspired by fast.ai
https://fluxml.ai/FluxTraining.jl
MIT License
118 stars 25 forks source link

`Recorder` does not work with models with non-`Array` inputs. #80

Closed lorenzoh closed 3 years ago

lorenzoh commented 3 years ago

Since Recorder tries to count the number of samples in a batch separately from those in a batch, it fails to get the batch size if the model input xs is not an array.

Possible solutions:

  1. remove the sample-counting
  2. add batchsize detection cases for other input types like Tuples and Dicts

I prefer 1. since the feature is not currently used, and it is not possible to exhaustively implement extra cases for batch size detection. Recorder should focus on counting the steps.

lorenzoh commented 3 years ago

Fixed by #81