innapropriate promotion in GAT layer

FluxML / GeometricFlux.jl

Geometric Deep Learning for Flux

https://fluxml.ai/GeometricFlux.jl/stable/

MIT License

348 stars 30 forks source link

innapropriate promotion in GAT layer #139

Closed jamesjscully closed 2 years ago

jamesjscully commented 3 years ago

The negative_slope argument is causing undesired promotion. This is easy enough to get around for, now, but at least the default value should be .2fo instead of .2 since the default datatype is Float32

yuehhua commented 3 years ago

Great thanks! It's a detail thing I didn't notice. I will fix it soon.