Closed ilancoulon closed 3 years ago
It actually also happens with Julia 1.5: https://github.com/FluxML/GeometricFlux.jl/pull/168/checks?check_run_id=2247858662#step:6:156
I don't really know what should be done here... Should we change the gather
name in ScatterNNLib? Or are both functions the same and we could then delete it in ScatterNNLib?
Yes, I am migrating scatter
and gather
to NNlib.jl, which is the dependency of Flux.jl.
While I still have to maintain the functionality of GeometricFlux.jl, I cannot purge ScatterNNlib.jl from GeometricFlux.jl.
Thus, an embarrassing situation happens............
The old functionality of ScatterNNlib.jl should be OK. Maybe I put a namespace of ScatterNNlib in GeometricFlux would work.
I'll do a PR with the namespaces of ScatterNNlib if that's ok!
Sorry, I could not push to your branch, so I create another PR for fixing advanced bugs.
When trying to test GeometricFlux on my computer using Julia 1.6, I get a conflict for the use of
gather
between Flux and ScatterNNLib. The beginning of the output is given at the end but the following line would be the only interesting one:WARNING: both ScatterNNlib and Flux export "gather"; uses of it in module GeometricFlux must be qualified
.Maybe this is related to https://github.com/yuehhua/ScatterNNlib.jl/issues/32 but I am not sure. I have the same kind of errors in my own package that uses GeometricFlux. Any idea about that error?