Implement GINConv layer.

FluxML / GeometricFlux.jl

Geometric Deep Learning for Flux

https://fluxml.ai/GeometricFlux.jl/stable/

MIT License

348 stars 30 forks source link

Implement GINConv layer. #186

Closed emsal0 closed 3 years ago

yuehhua commented 3 years ago

Could you post your full error message here?

emsal0 commented 3 years ago

Sure, here it is: https://gist.github.com/emsal0/e3d208e49c2b7dcd495c0b97a6fcc1ee

emsal0 commented 3 years ago

@yuehhua @CarloLucibello should I squash before requesting further review?

CarloLucibello commented 3 years ago

I guess squashing is better. Could you add the layer to the documentation in docs/?

emsal0 commented 3 years ago

Done, but forgot to squash. How can I preview my changes, formatted?

emsal0 commented 3 years ago

Manually squashing is ending up being more complicated than anticipated (due to the merge from master in the middle of the commit log), I think I will just leave it to the automatic squasher once review is done.