drop ScatterNNlib in favor of NNlib.scatter

FluxML / GeometricFlux.jl

Geometric Deep Learning for Flux

https://fluxml.ai/GeometricFlux.jl/stable/

MIT License

348 stars 30 forks source link

drop ScatterNNlib in favor of NNlib.scatter #191

Closed CarloLucibello closed 3 years ago

CarloLucibello commented 3 years ago

I see no issue for this, so better create one to track progress.

@yuehhua did you compare the performance of the two implementations?

CarloLucibello commented 3 years ago

Fixed by #187?

Do we have any regression?

yuehhua commented 3 years ago

@CarloLucibello I haven't benchmark them. The use of NNlib.scatter should work in master branch. I correct the arguments in #187. However, due to deps update and introduction of new features, #187 also makes new issues #194 and #195.