FluxML / GeometricFlux.jl

Geometric Deep Learning for Flux
https://fluxml.ai/GeometricFlux.jl/stable/
MIT License
348 stars 30 forks source link

remove learnable parameters when bias=false #196

Closed CarloLucibello closed 3 years ago

CarloLucibello commented 3 years ago

On current master, bias=false initialized the weights to zero, but the bias remains a learnable parameter. This PR fixes this problem and makes the interface consistent with Flux's initialization.

This PR also imposes stricter parametrization on layers' fields

This a breaking PR

CarloLucibello commented 3 years ago

this should be ready for review and merge

yuehhua commented 3 years ago

I am curious about assigning the element types of layer parameters. Shouldn't we provide a way for specifying the element types, such as T=Float32?

CarloLucibello commented 3 years ago

I am curious about assigning the element types of layer parameters. Shouldn't we provide a way for specifying the element types, such as T=Float32?

We discussed this at length in Flux. In the end the approach we took is the following: