Porting openai/gym's foundation classes to Gym.jl

FluxML / Gym.jl

Gym environments in Julia

MIT License

54 stars 19 forks source link

Porting openai/gym's foundation classes to Gym.jl #5

Closed kraftpunk97-zz closed 5 years ago

kraftpunk97-zz commented 5 years ago

Hi. I just wanted to get an opinion on porting openai/gym's foundational classes (Space, Env, etc) to Gym.jl and then building additional environments atop these base classes. My reasoning is that for someone who is coming from using openai/gym, transitioning to Gym.jl will be effortless, because they'd already be familiar with underlying structure of the package.

tejank10 commented 5 years ago

That's a good idea. A structured way to represent observation and action space is currently required.

kraftpunk97-zz commented 5 years ago

Cool. I'll start working on it right away.

kraftpunk97-zz commented 5 years ago

I wanted to know if for certain action spaces we should switch to 0-based indexing or stick with 1-based indexing. For example, should Discrete spaces begin with 0 or with 1?

tejank10 commented 5 years ago

Beginning with 1 would make it more julia-like.

kraftpunk97-zz commented 5 years ago

Closing Issue!