FluxML / IRTools.jl

Mike's Little Intermediate Representation
MIT License
111 stars 35 forks source link

fix #106 #107

Closed aviatesk closed 1 year ago

aviatesk commented 1 year ago

On the nightly Base._methods_by_ftype may return nothing in cases when it previously returned false instead.

PR Checklist

codecov-commenter commented 1 year ago

Codecov Report

Base: 74.94% // Head: 74.98% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (f8fdf97) compared to base (4f303b7). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #107 +/- ## ========================================== + Coverage 74.94% 74.98% +0.03% ========================================== Files 15 15 Lines 1417 1419 +2 ========================================== + Hits 1062 1064 +2 Misses 355 355 ``` | [Impacted Files](https://codecov.io/gh/FluxML/IRTools.jl/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Flux) | Coverage Δ | | |---|---|---| | [src/reflection/reflection.jl](https://codecov.io/gh/FluxML/IRTools.jl/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Flux#diff-c3JjL3JlZmxlY3Rpb24vcmVmbGVjdGlvbi5qbA==) | `84.74% <100.00%> (+0.53%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Flux). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Flux)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

bvdmitri commented 1 year ago

@aviatesk But how did it work before exactly? If it returned false it would still throw an error, because length(false) === 1.

ToucheSir commented 1 year ago

Thanks! Are you able to come up with a test for this path? Regardless of whether _methods_by_ftype returns false or nothing, we should be testing for both cases.

ToucheSir commented 1 year ago

Thanks @aviatesk !