Closed aviatesk closed 1 year ago
Base: 74.94% // Head: 74.98% // Increases project coverage by +0.03%
:tada:
Coverage data is based on head (
f8fdf97
) compared to base (4f303b7
). Patch coverage: 100.00% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@aviatesk But how did it work before exactly?
If it returned false
it would still throw an error, because length(false) === 1
.
Thanks! Are you able to come up with a test for this path? Regardless of whether _methods_by_ftype
returns false
or nothing
, we should be testing for both cases.
Thanks @aviatesk !
On the nightly
Base._methods_by_ftype
may returnnothing
in cases when it previously returnedfalse
instead.PR Checklist