Closed IanButterworth closed 1 year ago
first bad commit https://github.com/JuliaLang/julia/pull/49113
Test Summary: | Pass Fail Error Broken Total Time
IRTools | 24 1 26 1 52 26.3s
IR | 2 7 9 12.1s
Analysis | 3 3 0.8s
Reflection | 5 5 0.1s
Compiler | 2 19 1 22 3.8s
Relooper | 12 12 3.0s
Doctests: IRTools | 1 1 5.9s
ERROR: LoadError: Some tests did not pass: 24 passed, 1 failed, 26 errored, 1 broken.
commit before https://github.com/JuliaLang/julia/commit/8ca8ef3857b3ba272cb05ccc829dffe9e3cfdb48
Test Summary: | Pass Broken Total Time
IRTools | 60 1 61 33.0s
Testing IRTools tests passed
@aviatesk any tips on what to do here?
first bad commit JuliaLang/julia#49113
That would surprise me. The error comes from the changes in https://github.com/JuliaLang/julia/pull/48766. Basically, it is now forbidden to call code reflection from generated functions, unless explicitly managing codeinfo edges and invalidation thereof. In practice, this means using the lower-level form of @generated
which exposes the current world age, propagating that to the returned code info, and using it to invoke code reflection methods with (i.e. forward the world
argument).
A good example of this: https://github.com/JuliaDebug/CassetteOverlay.jl/pull/29
You're right, I was only looking at the test summary. It's actually hitting #108 on that commit
IR: Error During Test at /Users/ian/.julia/packages/IRTools/WiQqY/test/ir.jl:34
Test threw exception
Expression: foo(mylog2, 3.3) === mylog2(3.3)
MethodError: no method matching replace_code_newstyle!(::Core.CodeInfo, ::Core.Compiler.IRCode, ::Int64)
Closest candidates are:
replace_code_newstyle!(::Core.CodeInfo, ::Core.Compiler.IRCode)
Should be fixed by https://github.com/FluxML/IRTools.jl/pull/109
Even with #109 which seems to be the fix for #108 there are many issues in nightly CI #110
i.e.