search

FluxML / IRTools.jl

Mike's Little Intermediate Representation
MIT License
111 stars 35 forks source link

Adjust to EnterNode change #118

Closed Pangoraw closed 8 months ago

Pangoraw commented 9 months ago

the EnterNode struct was added in https://github.com/JuliaLang/julia/pull/52300 This commit adds support for ingesting and exporting CodeInfo with EnterNode but still uses Expr(:enter) inside IRTools IR. We may want to switch the representation to IRTools.EnterNode similarly to IRTools.Slot if more fields are added to the Core.EnterNode struct.

This PR should probably not be merged before https://github.com/JuliaLang/julia/pull/52309 which adds the scope field to EnterNode.

the broken test is fixed separately by #117.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6a9638c) 73.43% compared to head (5cdd662) 73.29%.

Files Patch % Lines
src/ir/print.jl 0.00% 2 Missing :warning:
src/ir/wrap.jl 75.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #118 +/- ## ========================================== - Coverage 73.43% 73.29% -0.15% ========================================== Files 16 16 Lines 1487 1494 +7 ========================================== + Hits 1092 1095 +3 - Misses 395 399 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.