search

FluxML / IRTools.jl

Mike's Little Intermediate Representation
MIT License
111 stars 35 forks source link

fix IRTools on Julia 1.6 #83

Closed simeonschaub closed 3 years ago

simeonschaub commented 3 years ago

Still needs https://github.com/JuliaLang/julia/pull/38519. This passes all tests for me locally, but coverage is not great, so there might still be cases I missed.

simeonschaub commented 3 years ago

Nightly tests pass! :tada: Could anyone merge this?

femtomc commented 3 years ago

@DhairyaLGandhi

DhairyaLGandhi commented 3 years ago

Thanks, this is great! I will run this with Zygote and Flux on 1.6, and get on it

simeonschaub commented 3 years ago

FYI, this isn't enough for Zygote yet. I have started working on that in this branch and a corresponding one for ZygoteRules, but I don't currently have time to further look into what it would take to get all Zygote tests to pass on 1.6

DhairyaLGandhi commented 3 years ago

Ah, alright, for now let's merge this, thanks again!

simeonschaub commented 3 years ago

Would it be possible to also tag a new release?