Closed simeonschaub closed 3 years ago
Nightly tests pass! :tada: Could anyone merge this?
@DhairyaLGandhi
Thanks, this is great! I will run this with Zygote and Flux on 1.6, and get on it
FYI, this isn't enough for Zygote yet. I have started working on that in this branch and a corresponding one for ZygoteRules, but I don't currently have time to further look into what it would take to get all Zygote tests to pass on 1.6
Ah, alright, for now let's merge this, thanks again!
Would it be possible to also tag a new release?
Still needs https://github.com/JuliaLang/julia/pull/38519. This passes all tests for me locally, but coverage is not great, so there might still be cases I missed.