search

FluxML / MLJFlux.jl

Wrapping deep learning models from the package Flux.jl for use in the MLJ.jl toolbox
http://fluxml.ai/MLJFlux.jl/
MIT License
145 stars 17 forks source link

Metalhead integration #206

Closed ablaom closed 2 years ago

ablaom commented 2 years ago

To close #205 and #162.

Does not need https://github.com/FluxML/Metalhead.jl/issues/176 but includes a temporary hack that can be removed when that is resolved. This PR defines a generic image_builder(Constructor) wrapper, but this won't work as advertised (and cannot be made public) until https://github.com/FluxML/Metalhead.jl/issues/176 is resolved.

WIP. See the image_builder docstring for more details.

Todos (incomplete):

codecov-commenter commented 2 years ago

Codecov Report

Merging #206 (64f9b3d) into dev (b3fa3a8) will decrease coverage by 3.18%. The diff coverage is 63.33%.

@@            Coverage Diff             @@
##              dev     #206      +/-   ##
==========================================
- Coverage   92.27%   89.09%   -3.19%     
==========================================
  Files           9       10       +1     
  Lines         246      275      +29     
==========================================
+ Hits          227      245      +18     
- Misses         19       30      +11
Impacted Files Coverage Δ
src/builders.jl 100.00% <ø> (ø)
src/metalhead.jl 62.06% <62.06%> (ø)
src/types.jl 85.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3fa3a8...64f9b3d. Read the comment docs.

ablaom commented 2 years ago

Closed in favour of #208