search

FluxML / MLJFlux.jl

Wrapping deep learning models from the package Flux.jl for use in the MLJ.jl toolbox
http://fluxml.ai/MLJFlux.jl/
MIT License
145 stars 17 forks source link

Add docstrings #207

Closed josephsdavid closed 2 years ago

josephsdavid commented 2 years ago

Docstrings and examples for exported models

ablaom commented 2 years ago

Let's put the new docstrings in the file where this line occurs:

https://github.com/FluxML/MLJFlux.jl/blob/b3fa3a82ecfa7da403582e41f6f51b32812ef9a0/src/types.jl#L100

That line, incidentally can be removed, along with the defintions of doc_regressor and doc_classifier which you are rendering redundant (maybe you can find something to use from there?) .

Can you please do that and open a new PR for review, closing this one

Thanks.

josephsdavid commented 2 years ago

Accidentally closed!