search

FluxML / MLJFlux.jl

Wrapping deep learning models from the package Flux.jl for use in the MLJ.jl toolbox
http://fluxml.ai/MLJFlux.jl/
MIT License
143 stars 17 forks source link

CompatHelper: bump compat for Metalhead to 0.8, (keep existing compat) #226

Closed github-actions[bot] closed 11 months ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the Metalhead package from 0.7 to 0.7, 0.8. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

ablaom commented 1 year ago

Metalhead 0.8 is breaking tests because the function Metalhead.vgg_conv_config is no longer defined. The offending line is here.

@darsnack What is the correct way to fix this test for Metalhead 0.8?

darsnack commented 1 year ago

You can refer to these instead. It should be the same structure but renamed variables.

DilumAluthge commented 11 months ago

@ablaom Any update here?

ablaom commented 11 months ago

Closed in favour of #232