Closed MarkArdman closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.34
:tada:
Comparison is base (
bf410e1
) 92.92% compared to head (97897ae
) 93.26%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Bug description
When a model is constructed with batch_size=0 it passes the clean! method without warning and batch_size remains at value 0. However the fit! method attempts to collate the data into batches which is not possible due to the Julia partition method (please find the method below) called in collate throwing an error when attempting to set n as 0.
I am not entirely certain if 0 is meant to stand for no batching or if un-batched training is not an intended feature, but currently I am assuming it is the latter due to the way training is done, with un-batched training basically not being possible. Therefore I assume this is an off-by-one error and have made the clean! method reject batch_size=0 along with everything below that.
PR Checklist