FluxML / MLJFlux.jl

Wrapping deep learning models from the package Flux.jl for use in the MLJ.jl toolbox
http://fluxml.ai/MLJFlux.jl/
MIT License
145 stars 17 forks source link

Update examples/MNIST Manifest, including Julia 1.10 #254

Closed ablaom closed 3 months ago

ablaom commented 4 months ago

This PR resolves #234. It updates the example/MNIST to use latest package versions and Julia 1.10

To do:

cc @EssamWissam

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.11%. Comparing base (b449d80) to head (638a19c). Report is 48 commits behind head on dev.

:exclamation: Current head 638a19c differs from pull request most recent head 0afbff1

Please upload reports for the commit 0afbff1 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #254 +/- ## ========================================== + Coverage 92.08% 92.11% +0.02% ========================================== Files 12 12 Lines 316 317 +1 ========================================== + Hits 291 292 +1 Misses 25 25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ablaom commented 4 months ago

OKay @EssamWisam I'm ready for you to have another look at this.

EssamWisam commented 3 months ago

OKay @EssamWisam I'm ready for you to have another look at this.

Redefines perfection 👌. I think we are ready to merge this just after we resolve anything, if needed, in my comment above.

EssamWisam commented 3 months ago

Oh and also after exposing it in the documentation: obvious by moving the tutorial to the docs folder and then putting the path in make.jl (in the commented tutorials section).

ablaom commented 3 months ago

I think we are ready to merge this just after we resolve anything, if needed, in my comment above.

Sorry, which comment is that?

Oh and also after exposing it in the documentation: obvious by moving the tutorial to the docs folder and then putting the path in make.jl (in the commented tutorials section).

Mmm. I'm going to postpone that step, but thanks for flagging.