Closed ablaom closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.11%. Comparing base (
b449d80
) to head (638a19c
). Report is 48 commits behind head on dev.:exclamation: Current head 638a19c differs from pull request most recent head 0afbff1
Please upload reports for the commit 0afbff1 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
OKay @EssamWisam I'm ready for you to have another look at this.
OKay @EssamWisam I'm ready for you to have another look at this.
Redefines perfection 👌. I think we are ready to merge this just after we resolve anything, if needed, in my comment above.
Oh and also after exposing it in the documentation: obvious by moving the tutorial to the docs
folder and then putting the path in make.jl
(in the commented tutorials section).
I think we are ready to merge this just after we resolve anything, if needed, in my comment above.
Sorry, which comment is that?
Oh and also after exposing it in the documentation: obvious by moving the tutorial to the docs folder and then putting the path in make.jl (in the commented tutorials section).
Mmm. I'm going to postpone that step, but thanks for flagging.
This PR resolves #234. It updates the example/MNIST to use latest package versions and Julia 1.10
To do:
acceleration=CUDALibs()
).cc @EssamWissam