Closed aviatesk closed 3 years ago
@cstjean can you have a quick review on this ? This doesn't change any fuctionality.
bump, @MikeInnes @cstjean ?
I approve the splitcombine
removal, but don't really know these other functions well enough to review. I'd be curious to know what's the improvement behind each of these changes though...
I'd be curious to know what's the improvement behind each of these changes though...
They're simply bugfixes, or attempts to improve runtime performance a bit or avoid invalidation risks by kindly telling some invariants to the compiler. The latter won't change any current behavior.
They're simply bugfixes
Can you provide a MWE triggering the bug and/or write a test for it?
Can you provide a MWE triggering the bug
MacroTools.splitstructdef(:(non_struct_ex(arg)))
maybe ?
Tests are added, should be good to go.
I'm going to use this example at our JuliaCon workshop and want to preserve these changes for that.
Should we reopen and merge this? I know it's been forever, but MacroTools hasn't changed much in the last 3 years, I assume we could probably merge it as is.
I ran JET analysis on this package, and fixed some true positive errors.