codecov-commenter
commented
1 year ago Codecov Report
Merging #186 (27f3954) into master (639d1a6) will decrease coverage by
0.99%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
- Coverage 74.68% 73.69% -1.00%
==========================================
Files 9 9
Lines 403 403
==========================================
- Hits 301 297 -4
- Misses 102 106 +4 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/match/types.jl | 58.82% <0.00%> (-5.89%) |
:arrow_down: |
| src/match/union.jl | 55.55% <0.00%> (-5.56%) |
:arrow_down: |
| src/match/match.jl | 91.04% <0.00%> (-2.99%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
cstjean
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.
See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29