search

FluxML / Metalhead.jl

Computer vision models for Flux
https://fluxml.ai/Metalhead.jl
Other
328 stars 65 forks source link

use julia-actions/cache in CI #260

Closed IanButterworth closed 10 months ago

IanButterworth commented 10 months ago

Just a fly-by suggestion while creating #259

julia-actions/cache is now more powerful and stores precompile caches

PR Checklist

IanButterworth commented 10 months ago

If you can, I recommend moving to the standard julia-actions/julia-runtest because it sets up coverage in a faster way and does parallel precompilation. The current setup here is hitting old serial precompilation (which is silently happening at the start of the test run)

IanButterworth commented 10 months ago

Multiplexing test groups via an env var that's handled in runtests.jl should be doable?

ToucheSir commented 10 months ago

Another problem: image Trying to normalize these suite names would be more yaml-foo than I want to deal with right now (because we still need them for ReTest to work properly). Come to think of it, this is probably why we don't use an env var too. Is there no way to make have the cache action work with them, given that they are still valid paths on *nix systems?

IanButterworth commented 10 months ago

That should be fixed upstream in the cache action