search

FluxML / Zygote.jl

21st century AD
https://fluxml.ai/Zygote.jl/
Other
1.48k stars 210 forks source link

@adjoint for logabsdet duplicates ChainRules rrule #1431

Closed ElOceanografo closed 1 year ago

ElOceanografo commented 1 year ago

In this issue (trying to sort out how to do reverse-mode AD for the logabsdet of sparse matrices), it was pointed out that Zygote's @adjoint for logabsdet duplicates and overrides an rrule in ChainRules. Would it make sense to delete that rule here and let ChainRules handle it?

ToucheSir commented 1 year ago

I'd say go for it. If tests pass it should be an easy merge.