search

FluxML / Zygote.jl

21st century AD
https://fluxml.ai/Zygote.jl/
Other
1.48k stars 210 forks source link

repeat with keywords causes scalar indexing #1442

Open DomCRose opened 1 year ago

DomCRose commented 1 year ago

xref: https://github.com/JuliaDiff/ChainRules.jl/issues/645#issue-1302826165

Making this since Zygote currently doesn't use the ChainRules rrules for repeat anyway.

Guessing best approach here would be to fix it in ChainRules first then swap Zygote over to the ChainRules rrules.

A useful gist to this end from @mcabbott: https://gist.github.com/mcabbott/80ac43cca3bee8f57809155a5240519f