Closed Pangoraw closed 1 month ago
I'm not really sure how to evaluate any risks from this change other than reading through the old PR. @oxinabox as the reviewer on that, would you be able to take a look here?
Tests are failing because an update to IRTools is needed (https://github.com/FluxML/IRTools.jl/pull/120).
@oxinabox is this still good to merge?
I see no reason why it wouldn't be. I thought it was merged back in January
This enables differentation support to try/catch when no exception is thrown on the try block.
The changes are twofolds:
:enter
and:leave
expressions, add an dedicated error message in the adjoint of the catch block instead.Here is an example of the behavior:
https://github.com/FluxML/IRTools.jl/pull/117 is a companion change that fixes some of the error that can currently happen with try/catch blocks in IRTools.jl.
Supersedes https://github.com/FluxML/Zygote.jl/pull/466.