FluxML / Zygote.jl

21st century AD
https://fluxml.ai/Zygote.jl/
Other
1.48k stars 213 forks source link

relation between builtin FillArray and FillArrays #190

Closed Roger-luo closed 5 years ago

Roger-luo commented 5 years ago

I'm trying to get rid of the mutation happens here

https://github.com/QuantumBFS/LuxurySparse.jl/blob/09795174112120a542fe15b786c8379e7e4b28dc/src/arraymath.jl#L29

with Fill (it doesn't make sense to add Zygote as deps for FillArrays) but I'm wondering if Zygote could use FillArrays directly, so there're no duplicated things.

And we could include some adjoints for FillArrays directly here since it is a dependency already.

MikeInnes commented 5 years ago

Closed by #191.