search

FluxML / ZygoteRules.jl

MIT License
15 stars 13 forks source link

nograd #1

Open willtebbutt opened 5 years ago

willtebbutt commented 5 years ago

It would be very helpful to have @nograd in this package. Looks like it would introduce an IRTools dependency though. Do we care?

edit: IRTools -> MacroTools

MikeInnes commented 5 years ago

I'm a bit wary of exposing @nograd because it tends to be overzealous (e.g. adding it to rand causes issues). Would a version that requires a signature be reasonable? Not strongly opposed anyhow.

We already depend on MacroTools; I'd like to remove that eventually but for now it makes no odds.

willtebbutt commented 5 years ago

A version that requires a signature would be preferable imho :) Is this something you've got time to implement?

MikeInnes commented 5 years ago

Yeah, I can give it a shot at some point.