Pass through ChainRules zeros in @adjoint too

FluxML / ZygoteRules.jl

MIT License

15 stars 13 forks source link

Pass through ChainRules zeros in @adjoint too #25

Closed ToucheSir closed 1 year ago

ToucheSir commented 1 year ago

After playing a grand game of whack-a-mole adding back(::AbstractZero) overloads in https://github.com/FluxML/Zygote.jl/pull/1389, it'd probably be better to enable this by default for all @adjoints. This change is effectively non-functional without that PR since @adjoint pullbacks should never see CR zero types, so I think it should be pretty safe until we trigger a PR like https://github.com/FluxML/Zygote.jl/pull/1389.

PR Checklist

[ ] Tests are added
[ ] Documentation, if applicable

CarloLucibello commented 1 year ago

Manifest.toml should be added to the .gitignore

ToucheSir commented 1 year ago

I added it to the .gitignore (which we didn't have before), but forgot to check the gitignore in!