Define literal_getproperty in ZygoteRules.jl?

FluxML / ZygoteRules.jl

MIT License

15 stars 13 forks source link

Define literal_getproperty in ZygoteRules.jl? #3

Closed tkf closed 5 years ago

tkf commented 5 years ago

I needed to overload Zygote.literal_getproperty to support differentiation through objects with customized Base.getproperty. It would be nice if its definition is moved to ZygoteRules.jl so that this can be done without importing whole Zyogte.

MikeInnes commented 5 years ago

Seem fair -- happy to accept a patch.

tkf commented 5 years ago

Thank you! I opened #5.

tkf commented 5 years ago

and https://github.com/FluxML/Zygote.jl/pull/332