search

FluxML / fluxml.github.io

Flux Website
https://fluxml.ai
MIT License
20 stars 45 forks source link

Fix issues post move to Franklin.jl #149

Closed darsnack closed 1 year ago

darsnack commented 1 year ago

Fixes the documentation link which broke after the port. It also adds missing assets for the blogs and tutorials. Closes #148. Closes #150.

github-actions[bot] commented 1 year ago

Once the build has completed, you can preview your PR at this URL: https://fluxml.ai/previews/PR149/

github-actions[bot] commented 1 year ago

Once the build has completed, you can preview your PR at this URL: https://fluxml.ai/previews/PR149/

darsnack commented 1 year ago

@Saransh-cpp looks like the preview pre-path doesn't carry over to links in posts.

I also don't know why certain posts don't have the title page environment variable getting picked up. Seems like a Franklin issue (cc @tlienart)?

tlienart commented 1 year ago

@darsnack can you point me to a page that has the issue you're talking about? or is it the items that get listed as Post 6 or Post 10? this is not an issue with Franklin but an issue with the function that does the listing of the posts; I'll have a look to see if I can fix it.

Separately, just had a quick look around (maybe this should go in a separate issue btw so we can go through it gradually), there seems to be a few issues with image links e.g. https://fluxml.ai/blogposts/2021-12-1-flux-numfocus/ looks like that's what this PR is about

darsnack commented 1 year ago

I am merging this to resolve the asset and docs link issues. I'll open up a discussion specifically for the hfun issue.

darsnack commented 1 year ago

can you point me to a page that has the issue you're talking about? or is it the items that get listed as Post 6 or Post 10? this is not an issue with Franklin but an issue with the function that does the listing of the posts; I'll have a look to see if I can fix it.

Sorry, I should have been more specific. I opened up #151 to track this.

Saransh-cpp commented 1 year ago

looks like the preview pre-path doesn't carry over to links in posts.

Hmm, I think this is happening because the navbar points to the folders available in the root directory -

https://github.com/FluxML/fluxml.github.io/blob/be5b604cabbda353d87e06d150793525dd3b832d/_layout/navbar.html#L13-L28

I'll try to fix this.

darsnack commented 1 year ago

Not just the navbar but also image assets which are inserted like /assets/...