Closed gouttegd closed 7 months ago
There is a couple of other problems in both the #1750 and #1754 PRs (which should again have been caught by the test suite, but were not because of the aforementioned bug):
definitions.owl
contains a weird class declaration:Declaration(Class(<http://purl.obolibrary.org/obo/FBbt_>)
This is caused by this line in the developingEntityWithEarlierAndLaterStructures.tsv
data file:
FBbt:00007049 head visceral muscle primordium FBbt:00005495 primordium FBbt:
We do not have a head visceral muscle
term, so we should either create it or remove that line.
This is caused by a couple of errors in the anatomicalEntityBySegment.tsv
data file:
mesothoracic dorsal acute muscle
is classified as part of some larval prothoracic segment
mesothoracic oblique muscle
, one of them assigning the muscle to the larval prothoracic segment
.Haha, how strange - not sure how that happened, would have expected dosdp to throw an error if an invalid id is used... We probably don't want the primordium term if we don't have a term for 'head visceral muscle', but that is not for this ticket - I will sort out the 'head visceral muscle primordium' term for now
I’m already on it, I can submit a PR in a moment. :)
Since PR #1750, some terms for primordia and anlagen end up with multiple definitions (one generated from the pattern and one that was already “manually” set on the term). This is not allowed and results in a failure of the build pipeline:
This was not caught by the CI check because, while the error did occur during the check for PR #1750, the test still returned success because of an horrendous bug in the ODK.