Remove 'alt_id' on obsolete terms.

[gouttegd]

The alt_id tag carried by a term is interpreted as a way to signify both

• that the term pointed by the tag is obsolete, and
• that it is replaced by the term carrying the tag.

We had 4 instances where the tag was used to point to terms that were already marked as obsolete through the use of the is_obsolete tag, and for unclear reasons the simultaneous use of alt_id and is_obsolete seemed to disturb the OBO serializer in Protégé, leading it to serialize the obsoleted terms as OWL in the top-level owl-axioms: stanza.

To avoid that, this PR removes the offending alt_id tags. They are not needed anyway since, as stated, the referenced terms are already marked as obsolete (and they also have consider annotations to point curators to possible replacement terms).

[Clare72]

I did the obsoletion of the four terms with the alt_id annotations the other day. Oddly I did not see these owl axioms appearing at the time (and they are not committed to git), but I do see them now when I reserialise the master branch. I think your PR might be failing because there are no labels on the earlier-obsoleted terms (I guess chado_load_checks was able to use the labels on the newly-obsoleted terms due to the alt_ids). I will poke around and try to find the old labels (possibly in the svn somewhere), or if I can't find them, maybe we can make something up (since terms are obsolete anyway).

[Clare72]

Ok, having looked through the svn, it doesn't seem as though the older terms were ever in a released version as standalone terms. The segment pair terms just appear around Feb 2011 (before FBbt on Git) with the alt_ids. So maybe we can just call them 'obsolete fan-shaped body segment pair W 2' etc?

[gouttegd]

I think your PR might be failing because there are no labels on the earlier-obsoleted terms

Yes, that was my understanding as well.

Thanks for checking the history. I agree with crafting new names as you suggest.