FlyBase / drosophila-phenotype-ontology

The home of the Drosophila phenotype ontology
Creative Commons Attribution 4.0 International
4 stars 1 forks source link

add missing namespace to new phenotypic class terms #106

Closed gm119 closed 3 years ago

gm119 commented 3 years ago

All FBcv terms under the term 'phenotypic class' (FBcv:0000347) should have the namespace line:

namespace: phenotypic_class

However, some of the FBcv terms added recently are missing the namespace.

The namespace is needed for checking of curation, as the FBcv contains a multitude of different types of terms - having the namespace allows checking that the right 'type' of FBcv term has been used in different curation contexts/fields. (Its possible that this requirement could be replaced and the ontology tree could be used in future instead of namespace, but there may be other requirements for namespace for other applications other than curation checking, and it would require a lot of code changes to change the checking, so it would be easiest to just add the namespace to the terms where it is missing!)

Ones I found with a missing 'phenotypic_class' namespace are included below, but there may be others (I don't know to search exhaustively, sorry!)

[Term] id: FBcv:0007504 name: abnormal body weight def: "Phenotype that is any abnormality in body weight compared to identically raised wild-type controls." [FBC:CP] is_a: FBcv:0001347 ! phenotype created_by: http://orcid.org/0000-0002-1373-1705 creation_date: 2020-12-15T15:47:07Z

[Term] id: FBcv:0007505 name: increased body weight def: "Phenotype that is an increase in body weight compared to identically raised wild-type controls." [FBC:CP] is_a: FBcv:0001347 ! phenotype created_by: http://orcid.org/0000-0002-1373-1705 creation_date: 2020-12-15T15:50:18Z

[Term] id: FBcv:0007506 name: decreased body weight def: "Phenotype that is a decrease in body weight compared to identically raised wild-type controls." [FBC:CP] is_a: FBcv:0001347 ! phenotype created_by: http://orcid.org/0000-0002-1373-1705 creation_date: 2020-12-15T15:50:44Z

Clare72 commented 3 years ago

Already fixed by #96 in relation to #107

gm119 commented 3 years ago

oops, sorry about the duplication, will remember to check existing tickets in future !