search

FlyBase / drosophila-phenotype-ontology

The home of the Drosophila phenotype ontology
Creative Commons Attribution 4.0 International
4 stars 1 forks source link

MERGE: Process patterns #30

Closed Clare72 closed 5 years ago

Clare72 commented 5 years ago

related to #29

'flightless' previously used PATO:'absent' but using abnormalAbsenceOfBiologicalProcess pattern (uses 'lacking processual parts')

matentzn commented 5 years ago

This is great! :) Two things: 1) If you dont want a pull request to be merged, you can use the phrase DO NOT MERGE: as a prefix to the title of the request. For example this one could be called: DO NOT MERGE: Process patterns. If you remove the DO NOT MERGE you are suggesting it is ready to be reviewed/merged. 2) When we move from PATO based phenotyping, to pattern-based, we deliberately should forget about the PATO classes used in the pattern; It is highly likely they will change at some point. For example absent; I am pretty certain we will return to using PATO:absent instead of lacking processual parts. So the only question you need to answer is: does the pattern apply; not does the PATO term used in the pattern apply.