search

FlyRanch / figurefirst

A layout-first approach to figure making
http://flyranch.github.io/figurefirst
MIT License
80 stars 15 forks source link

edits for stylistic consistency #40

Closed lemonez closed 6 years ago

lemonez commented 6 years ago

In docstring for mpl_fig_to_figurefirst_svg(), no output filepath was specified; should be 'output_filename' ?

psilentp commented 6 years ago

Thanks for the help!

lemonez commented 6 years ago

Most def. Thanks for showing me these modules, I'm definitely going to play around with it and see how I can incorporate into my projects.

On Sat, Sep 15, 2018, 20:40 Theodore Lindsay notifications@github.com wrote:

Thanks for the help!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FlyRanch/figurefirst/pull/40#issuecomment-421683386, or mute the thread https://github.com/notifications/unsubscribe-auth/AiswANE1UltSdMJe7UQAr1HThfbqfQ9iks5ubcg3gaJpZM4Wqov9 .

lemonez commented 6 years ago

The 'dill' package seems to not come with basic Anaconda Python 3.6 distribution, which I just reinstalled. So I had to download it manually with conda, no big deal but I thought I'd mention this in case it should be noted in the 'setup' docs as far as dependencies.

On Sun, Sep 16, 2018 at 9:40 AM Ezra Citron citron.ezra@gmail.com wrote:

Most def. Thanks for showing me these modules, I'm definitely going to play around with it and see how I can incorporate into my projects.

On Sat, Sep 15, 2018, 20:40 Theodore Lindsay notifications@github.com wrote:

Thanks for the help!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/FlyRanch/figurefirst/pull/40#issuecomment-421683386, or mute the thread https://github.com/notifications/unsubscribe-auth/AiswANE1UltSdMJe7UQAr1HThfbqfQ9iks5ubcg3gaJpZM4Wqov9 .

-- A sound mind in a sound body is a short but full description of a happy state in this world. -John Locke, philosopher (1632-1704)

florisvb commented 6 years ago

Thanks - I made a note in the README.. eventually we should organize that more..

Also made a bunch of updates to the regenerate.py to get it working with python 3.

On Sun, Sep 16, 2018 at 1:36 PM ezcitron notifications@github.com wrote:

The 'dill' package seems to not come with basic Anaconda Python 3.6 distribution, which I just reinstalled. So I had to download it manually with conda, no big deal but I thought I'd mention this in case it should be noted in the 'setup' docs as far as dependencies.

On Sun, Sep 16, 2018 at 9:40 AM Ezra Citron citron.ezra@gmail.com wrote:

Most def. Thanks for showing me these modules, I'm definitely going to play around with it and see how I can incorporate into my projects.

On Sat, Sep 15, 2018, 20:40 Theodore Lindsay notifications@github.com wrote:

Thanks for the help!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/FlyRanch/figurefirst/pull/40#issuecomment-421683386 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AiswANE1UltSdMJe7UQAr1HThfbqfQ9iks5ubcg3gaJpZM4Wqov9

.

-- A sound mind in a sound body is a short but full description of a happy state in this world. -John Locke, philosopher (1632-1704)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FlyRanch/figurefirst/pull/40#issuecomment-421828857, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPCPOPfvNhLoFcOGtscSuKq8yRBFpyBks5ubrZagaJpZM4Wqov9 .

-- Floris van Breugel Currently: Moore-Sloan / Sackler Fellow at UW, Seattle, WA Soon: Assistant Professor of Mechanical Engineering at UNR, Reno, NV Science: http://www.florisvanbreugel.com

Wildlife and Landscape Photography Galleries: http://www.ArtInNaturePhotography.com/ Blog: http://www.ArtInNaturePhotography.com/wordpress/

psilentp commented 6 years ago

Cool - popped it into the requirements section of the documentation as well. We should work out the min versions needed and pop them into a requirements.txt file and get a pip installer working.

florisvb commented 6 years ago

That would be cool..

On Mon, Sep 17, 2018 at 1:11 PM Theodore Lindsay notifications@github.com wrote:

Cool - popped it into the requirements section of the documentation as well. We should work out the min versions needed and pop them into a requirements.txt file and get a pip installer working.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FlyRanch/figurefirst/pull/40#issuecomment-422153801, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPCPNH887QbuwasPzkvs_HkxOhn06dWks5ucAHzgaJpZM4Wqov9 .

-- Floris van Breugel Currently: Moore-Sloan / Sackler Fellow at UW, Seattle, WA Soon: Assistant Professor of Mechanical Engineering at UNR, Reno, NV Science: http://www.florisvanbreugel.com

Wildlife and Landscape Photography Galleries: http://www.ArtInNaturePhotography.com/ Blog: http://www.ArtInNaturePhotography.com/wordpress/