search

FlyRanch / figurefirst

A layout-first approach to figure making
http://flyranch.github.io/figurefirst
MIT License
80 stars 15 forks source link

Test on python 3.8 #56

Open psilentp opened 4 years ago

psilentp commented 4 years ago

Issue originally pointed out in #55 by @clbarnes.

clbarnes commented 4 years ago

I'm intrigued - the Actions config doesn't give the name of a tox env specified in the tox config, and the tox config doesn't include 3.8, but Actions does. How does that all work?

Either way, I think that explicitly installing the dependencies outside of tox isn't necessary - tox will install the dependencies in a fresh environment itself.

psilentp commented 4 years ago

Yes, that was sloppy on my part -- the build and test are redundant.

psilentp commented 4 years ago

It might also be useful to setup the CI to publish tagged releases. https://packaging.python.org/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/ -- Though that is probably another issue.

psilentp commented 4 years ago

I'm intrigued - the Actions config doesn't give the name of a tox env specified in the tox config, and the tox config doesn't include 3.8, but Actions does. How does that all work?

To answer your question I think this bit of trickery suggested by the github actions tutorial is supposed line up the environments.

https://github.com/FlyRanch/figurefirst/blob/c8cad3d18f2eaa62ed418649918bc3c0fbdaf252/.github/workflows/continuous-integration-workflow.yml#L29

Not sure if this is the best approach.