Flying-Book / CSP_home

Apache License 2.0
0 stars 0 forks source link

Data Structures Writeup Review #11

Open Flying-Book opened 2 months ago

Flying-Book commented 2 months ago

https://flying-book.github.io/CSP_home/2024/02/12/Data-Structures_IPYNB_2_.html

vibha-yganji commented 2 months ago

Grading: (in progress)

Collections: 0.95/1

All the requirements are met. I like how the blog explains the connections between two different collection structures (the SQlite Database and the .csv file).

Lists + Dictionaries:0.92/1

I like how you included more examples for lists than needed. However, I think the commentary about the purpose of the dictionaries could be a little more in-depth. The pictures are much clearer in this example but I think using some sort of editing tool on top of them could help the reader understand the parts of the code you are referencing to.

APIs and JSON: 0.9/1

The explanations for the APIs and Error Messages are good. I like how you still included an example of a 401 error from a previous project you did even though your contribution the the Data Structures Project used different code. However, I would have liked to see the code behind a couple other CRUD functions other than just GET and POST.

Frontend: 0.86/1

Though you had a lot of comments in the code, I think a little more explanation on the blog itself would be good. The images and commentary for the success and failure images were very good. I think however, you are missing the json formatting code from the GET function.

Machine Learning:

Total: Extra ML Credit:

Flying-Book commented 1 month ago

Extra pictures: image image image image

image image