search

FlyingPumba / SimpleRatingBar

Open source project which features a simple yet powerful RatingBar alternative to Android's default
Apache License 2.0
1.03k stars 142 forks source link

Attribute "stepSize" has already been defined #7

Closed amorenew closed 8 years ago

amorenew commented 8 years ago

Hi i put your library to gradle and i got this error: Error:(669) Attribute "stepSize" has already been defined in \app\build\intermediates\res\merged\debug\values\values.xml i have in it

<attr format="integer" name="stepSize"/>
<attr format="float" name="stepSize"/>

Note: my gradle: compile('com.mikepenz:materialdrawer:5.3.6@aar') { transitive = true } compile('com.mikepenz:fastadapter:1.6.0@aar') { transitive = true } compile(name: 'horizontal_number_picker', ext: 'aar') compile(name: 'wheel_picker', ext: 'aar') compile 'com.mikepenz:itemanimators:0.2.4@aar' compile 'com.mikepenz:fastadapter-extensions:1.6.0@aar' compile 'com.android.support:appcompat-v7:23.4.0' compile 'com.android.support:support-v4:23.4.0' compile 'com.android.support:design:23.4.0' compile 'com.android.support:cardview-v7:23.4.0' compile 'com.android.support:recyclerview-v7:23.4.0' compile 'com.google.code.gson:gson:2.7' compile 'com.android.volley:volley:1.0.0' compile 'com.github.bumptech.glide:glide:3.7.0' compile 'com.android.support.constraint:constraint-layout:1.0.0-alpha5' //using custom library for date picker because native date picker select disabled dates compile 'com.wdullaer:materialdatetimepicker:2.4.0' //for cart count badge in toolbar compile 'com.mikepenz:actionitembadge:3.2.6@aar' compile 'com.cocosw:bottomsheet:1.+@aar' compile 'uk.co.chrisjenx:calligraphy:2.2.0' compile 'com.jakewharton:butterknife:8.2.1' apt 'com.jakewharton:butterknife-compiler:8.2.1' testCompile 'junit:junit:4.12' //i use custom rating bar because android native bar isn't fully resizable compile 'com.iarcuschin:simpleratingbar:0.0.5' Thanks

FlyingPumba commented 8 years ago

Hi, thanks for the bug report ! I'll change the attribute name in next version so it doesn't collide with other libraries.

amorenew commented 8 years ago

thanks

amorenew commented 8 years ago

i found the problem in horizontal number picker i forked to add feature to it i changed stepSize to stepCount in forked library https://github.com/amorenew/HorizontalNumberPicker/commit/46e635ffcb39db696c788748921a8837627f647d

FlyingPumba commented 8 years ago

Amazing ! thanks. I'll probably change it anyway, to something like ratingStepSize, to avoid possible problems to other users.

emauro commented 8 years ago

The same problem happens with FillColor

amorenew commented 8 years ago

it's better to put prefix like ratingStepSize , ratingFillColor, etc really good work

FlyingPumba commented 8 years ago

I decided a different approach. I realized that libraries like FAB add a prefix fab_ to the attributes, so I'm adding srb_. Already pushed to jcenter and Maven Central as version 0.0.7, try it out ! :)