Fmstrat / ownnote

Notes app for ownCloud
GNU Affero General Public License v3.0
168 stars 42 forks source link

Incompatibility with ownCloud 10 #348

Open BellHouse opened 6 years ago

BellHouse commented 6 years ago

ownCloud 10 requires signed addons. ownNote triggers a failure of the integrity check on this ownCloud release, and cannot be enabled.

`Technical information

The following list covers which files have failed the integrity check. Please read the previous linked documentation to learn more about the errors and how to fix them.

Results

Raw output

Array ( [ownnote] => Array ( [EXCEPTION] => Array ( [class] => OC\IntegrityCheck\Exceptions\InvalidSignatureException [message] => Signature data not found. )

    )

)`

TobeStokes commented 6 years ago

I was able to get OwnNote working with Owncloud 10 by changing the "max-version" setting to 10.0 in the file /var/www/html/owncloud/apps/ownnote/appinfo/info.xml

I'm using Owncloud v10.0.7.2 on CentOS 7.

This doesn't fix the signature being missing, so the Admin side of things still shows the integrity check error. But it allows me to use OwnNote just as before the update from 9.1

hannesa2 commented 5 years ago

@TobeStokes Great ! Any idea how to get rid of the Signature data not found. ?

hannesa2 commented 5 years ago

Or what's an alternative with more chance of support in the future ? Nextcloud ?

Poikilos commented 5 years ago

Even with max-version hack, the app doesn't work on ownCloud 10.0.10. Clicking on the notes app does nothing, and the Android ownNote app cannot connect to server, though worked fine before upgrade from ownCloud 9.

Fmstrat commented 5 years ago

I will take a look soon when I update for nextcloud 15.

Input-BDF commented 5 years ago

Hej there. Version "hack" is one way but let's say ... nothin ^^

Also get an WSOD and looked into my error logs. PHP Fatal error: Call to undefined method OC\\Server::getContentSecurityPolicyNonceManager() in /home/user/0_public/2_cloud/apps2/ownnote/templates/main.php on line 21 Line 21: <input type="hidden" name="nextNonce" id="nextNonce" value="<?php p(\OC::$server->getContentSecurityPolicyNonceManager()->getNonce()) ?>" />

Since I have no Idea yet what this input field is for and this server is my "Playground" i simply commented the php value part out. At least my notes show up again.

TobeStokes commented 5 years ago

Even with max-version hack, the app doesn't work on ownCloud 10.0.10. Clicking on the notes app does nothing, and the Android ownNote app cannot connect to server, though worked fine before upgrade from ownCloud 9.

Another user has posted a commit to this project saying that the max-version hack does work with v10.0.10 if you put in "10.0.10" where I just had "10.0" before. See the details here:

https://github.com/Fmstrat/ownnote/commit/46e9245de66ec1daa70a15bbdf3f521afac35f34?_pjax=%23js-repo-pjax-container

I haven't tested yet but I might give it a whirl this weekend.

Fmstrat commented 5 years ago

@TobeStokes Let me know, if so I'll adjust the repo. Thanks!

TobeStokes commented 5 years ago

@Fmstrat Well I did an upgrade to 10.0.10 and it still works the same. I didn't even change my "10.0" entry in the xml file.

I did notice on another Owncloud-related GitHub project that there was a change to the "max-version" thing to just "10" so that may be the standard now. I'll try to find that for reference.

Edit: here it is, on the Brute-Force Protection project:
https://github.com/owncloud/brute_force_protection/pull/50

Stated reason for their change is "Because core platform is switching to Semver"

devplan44 commented 5 years ago

Ownnote returns with server error on hosted server: Results

Raw output

Array ( [ownnote] => Array ( [EXCEPTION] => Array ( [class] => OC\IntegrityCheck\Exceptions\MissingSignatureException [message] => Signature data not found. )

    )

)

How do I resolve this?

cpunk commented 5 years ago

How do I resolve this?

Install 'Notes' from the Owncloud marketplace on your server, it is signed and works: https://marketplace.owncloud.com/apps/notes

It works well with Nextcloud Notes on your Android device: https://play.google.com/store/apps/details?id=it.niedermann.owncloud.notes or https://f-droid.org/en/packages/it.niedermann.owncloud.notes/