Fullscreen button causes Window to "Fullscreen" to all of my Monitors

Fmstrat / winapps

Run Windows apps such as Microsoft Office/Adobe in Linux (Ubuntu/Fedora) and GNOME/KDE as if they were a part of the native OS, including Nautilus integration.

8.68k stars 407 forks source link

Fullscreen button causes Window to "Fullscreen" to all of my Monitors #26

Open zimsneexh opened 3 years ago

zimsneexh commented 3 years ago

Basically as the title says. I'm using Plasma 5 and if i press a "maximize" button it resizes the window not to fullscreen of one monitor, but all of them.

Is this an issue with freerdp or is this somehow fixable?

Fmstrat commented 3 years ago

Ahh, very happy you are here to help debug this. On my triple monitor setup, it always maximizes to monitor 3 (Xorg, GNOME).

What is your full setup?

Can you try removing /span from this line? https://github.com/Fmstrat/winapps/blob/88475546f260725c0fe4a3350cc0a5d5c81043b0/bin/winapps#L79

zimsneexh commented 3 years ago

I'm running Plasma5 with Xorg on Archlinux.

Removing /span makes the window maximize properly on all but the Primary monitor, where Maximizing it causes the Window to become unclickable.

kolle86 commented 3 years ago

Replacing /span with /multimon works on my dual monitor setup. Maximizing and moving windows between monitors works as expected

Fmstrat commented 3 years ago

@kolle86 Can you describe your system to me? Whenever I have tested this I get a black window.

Fmstrat commented 3 years ago

https://github.com/FreeRDP/FreeRDP/issues/5206

kolle86 commented 3 years ago

@Fmstrat I'm on Fedora 33, GNOME with X (not wayland), freerdp 2.2.0

Fmstrat commented 3 years ago

Hmm, the only difference here is Fedora vs Ubuntu. What graphics card and driver do you use?

For now, I've added a MULTIMON configuration option that will swap span with multimon.

kolle86 commented 3 years ago

NVIDIA GP106 with proprietary driver.

Fmstrat commented 3 years ago

@kolle86 Hmm, can you supply the driver version?

kolle86 commented 3 years ago

@Fmstrat
Driver Version: 455.38 CUDA Version: 11.1

thegrasshopper104 commented 3 years ago

I have the same issue on KDE Neon focal and nvidia. I can only maximise an app to stretch both monitors.

dgalli1 commented 3 years ago

Not a fix but a workaround that i tested on KDE with a triple monitor setup. This script maximize the window via xdotool. And this seems to work Maybe this script will be useful for someone, personally i set a hotkey to maximize xfreerdp windows.

#!/bin/bash
winid=$(xdotool getactivewindow)
maxSize=$(xdotool getdisplaygeometry)
eval "$(xdotool getwindowgeometry --shell $winid)"
screen=$(expr $X / 1920)
offsetPos="$(($screen*1920))"
xdotool windowmove $winid $offsetPos 0
xdotool windowsize $winid $maxSize