search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
434 stars 55 forks source link

Condense 3x2 and 4x2 #100

Closed GrylledCheez closed 1 year ago

GrylledCheez commented 1 year ago

I combined the 3x2 and 4x2 switchcases since they were basically the same. I haven't seen any troubles since I did that. If you accept this one, I'll go ahead and combine the 2x2 as well. This will allow us to easily extend to rows and more columns, i.e. 3x3, 4x3, etc

GrylledCheez commented 1 year ago

@Fmstrat, let me know what you think. I'm open to coding changes. I also didn't increment the version because I didn't know how you wanted to do it.

phavekes commented 1 year ago

could you rebase this to the latest develop-branch, so I can test it on gnome 44?

GrylledCheez commented 1 year ago

This is based off of the latest master branch that includes gnome 43 and 44. Am I missing something other than the commits you made 6 minutes ago?

phavekes commented 1 year ago

https://github.com/Fmstrat/wintile/compare/master...develop

GrylledCheez commented 1 year ago

Can you cherry-pick it to test?

GrylledCheez commented 1 year ago

@phavekes, I changed the branch I'm merging into (develop). Is that what you meant? When I forked the repo, it only cloned master.

GrylledCheez commented 1 year ago

Closing for now