search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

Fix mouse events #101

Closed GrylledCheez closed 1 year ago

GrylledCheez commented 1 year ago

resolves #97

GrylledCheez commented 1 year ago

@phavekes, did you ever accept the maintainer position? If you did, would you look over my 2 PRs?

GrylledCheez commented 1 year ago

That's merely a string ")" to conform with the other logs.

phavekes commented 1 year ago

When trying your modified extension.js, I get an error expected expression, got ')' You are right that the log string can't be the issue, but I don't see where the error emits

image

GrylledCheez commented 1 year ago

I swapped this one to draft and I'll track it down tomorrow. The other PR is more important. Let me know what you think

Fmstrat commented 1 year ago

@rsxchin As you are pretty active in PRs, would you like to be added as a maintainer officially? I have not been able to dedicate the appropriate amount of time here, so I'm sure @phavekes would appreciate the help. Thanks!

GrylledCheez commented 1 year ago

@Fmstrat, I'll do what I can

GrylledCheez commented 1 year ago

I'm closing this pr in favor of another smaller one