Add linter and perform corrections

[GrylledCheez]

only a few errors left. but I'm tired

• [x] 1:1 error Definition for rule 'jsdoc/newline-after-description' was not found jsdoc/newline-after-description
• [x] 61:1 error Unexpected use of 'window' no-restricted-globals
• [x] 65:28 error Unexpected use of 'window' no-restricted-globals
• [x] 807:24 error 'settings' is already declared in the upper scope on line 20 column 5 no-shadow
• [x] 1107:10 error 'enable' is defined but never used. Allowed unused vars must match /(^unused|_$)/u no-unused-vars
• [x] 1146:115 error 'gpointer' is defined but never used. Allowed unused args must match /^(unused|_)/u no-unused-vars
• [x] 1152:111 error 'gpointer' is defined but never used. Allowed unused args must match /^(unused|_)/u no-unused-vars
• [x] 1183:10 error 'disable' is defined but never used. Allowed unused vars must match /(^unused|_$)/u no-unused-vars
• [x] 1190:9 error 'shellSettings' is assigned a value but never used. Allowed unused vars must match /(^unused|_$)/u no-unused-vars

[phavekes]

Is it necessary to commit the node_modules folder? Could you add it to .gitignore?

[GrylledCheez]

I guess you're right

[Fmstrat]

Hey @GrylledCheez, please roll back the commits or start a new branch pre-merge without node_modules. Having the commit included increases the size of the repo significantly.

This may need to be started in a fully separate branch as a patch to get rid of the history completely. Thanks!

[GrylledCheez]

@Fmstrat, did that work?

[GrylledCheez]

All js files linted

• [x] extension.js
• [x] prefs.js
• [x] keybindings.js

I didn't increment the version, since it's not functionally different to the v10 release. Feel free to inc it if you want.

[GrylledCheez]

What's the concensus for adding hooks/pre-commit that will run eslint before accepting a commit? https://gist.github.com/broofa/730fab6ceb1686f4a1fa9977b791b1b5

[GrylledCheez]

@phavekes, stop force pushing. Just do single commits. We can squash them in a rebase later.

[phavekes]

@phavekes, stop force pushing. Just do single commits. We can squash them in a rebase later.

Sorry for that. Can't get eslint to work in GHA.

[GrylledCheez]

For some reason, your commit messed up the tabbing in the .eslintrc.yml for

- 'CallExpression[callee.object.name=GObject][callee.property.name=registerClass] > ClassExpression:first-child'

It should line up with the comments above it

[GrylledCheez]

@phavekes, I'm going to revert and force push back, and we can pretend none of this happened :D This branch is cursed.

[GrylledCheez]

be sure to do a git fetch --all to make sure you have a clean history

[GrylledCheez]

I'm going to abandon this branch for now. But we will still need to do lining before the next version. For now keep pulling to the develop branch and we can do a lint there when we're ready.