search

Fmstrat / wintile

Windows 10 window tiling for GNOME
GNU General Public License v3.0
424 stars 54 forks source link

Merge Develop into master for v11 #124

Closed GrylledCheez closed 1 year ago

GrylledCheez commented 1 year ago

There are a lot of scary looking changes, but that's mostly due to swapping tabs for spaces and adding commas to the end of lists per the style guide.

Some notable changes include

  1. updating the gitignore to exclude node_modules/ for the future
  2. fixed animation stutter
  3. added a zone on the bottom that will spawn at full width on the bottom row
  4. build.sh starts clean before building and we made the arguments easier to read
  5. fixed the pixels on the right of screens by tacking them onto the end of the last column
  6. updated the README.md and metadata.json
  7. incremented the version to 11
  8. ADDED AUTOMATIC LINTER FOR PUSHES AND PULLS TO DEVELOP OR MASTER
  9. linted all 3 js files with the gjs style guide.
    • swapped tabs for spaces
    • added jsdoc explanations for each function
    • removed dead functions that have no callers
    • changed all snake case to camel case (just_some_variable vs justSomeVariable)
    • made all comparisons === instead of == because that's what they want for some reason
    • swapped all concatenated log strings with interpolated strings

@Fmstrat, please let us know what you think and if there are any changes you need.

GrylledCheez commented 1 year ago

I just want to ask that this gets squashed on merge.

GrylledCheez commented 1 year ago

@phavekes, are you comfortable with these changes?

GrylledCheez commented 1 year ago

@Fmstrat, please, please, please accept this PR.... https://github.com/Fmstrat/wintile/pull/124/files?w=1

GrylledCheez commented 1 year ago

@ba32107 and @phavekes, I just need 1 of you to approve. If neither of you want of be maintainers anymore, please tell @Fmstrat

GrylledCheez commented 1 year ago

@phavekes, I didn't mean for that to sound as threatening as it was.

phavekes commented 1 year ago

@GrylledCheez Why did you delete develop?

GrylledCheez commented 1 year ago

Merely to recreate it and sync it with master. (But really, because master had 1 commit ahead of it (that was already included) )

GrylledCheez commented 1 year ago

Would you kindly make a v11 tag and submit a properly worded release?

ba32107 commented 1 year ago

I do not have time to maintain this project anymore, @Fmstrat feel free to remove me